Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] chart: support import/export of dataset trendlines #5318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] chart: support import/export of dataset trendlines #5318

wants to merge 1 commit into from

Conversation

Rachico
Copy link
Contributor

@Rachico Rachico commented Dec 5, 2024 •
edited
Loading

This commit introduces the ability to import and export trendlines associated with datasets in chart configurations.

Task: 4319957

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Dec 5, 2024

Pull request status dashboard

@Rachico Rachico force-pushed the master-import-export-trendlines-mera branch 3 times, most recently from 2d5c4c7 to 83539de Compare December 5, 2024 13:38
@Rachico Rachico requested a review from anhe-odoo December 6, 2024 09:10
@Rachico Rachico marked this pull request as ready for review December 6, 2024 09:10
@Rachico Rachico force-pushed the master-import-export-trendlines-mera branch from 83539de to ec88721 Compare December 6, 2024 09:36
anhe-odoo
anhe-odoo reviewed Dec 6, 2024
View reviewed changes
src/xlsx/conversion/figure_conversion.ts Outdated Show resolved Hide resolved
src/helpers/figures/charts/chart_common.ts Outdated Show resolved Hide resolved
@Rachico Rachico force-pushed the master-import-export-trendlines-mera branch 3 times, most recently from 5dec1f9 to 4db8ba5 Compare December 11, 2024 10:33
@Rachico Rachico force-pushed the master-import-export-trendlines-mera branch 7 times, most recently from 25e3cc0 to 133cff2 Compare December 19, 2024 16:56
anhe-odoo
anhe-odoo reviewed Dec 20, 2024
View reviewed changes
src/helpers/figures/charts/chart_common.ts Outdated Show resolved Hide resolved
src/xlsx/extraction/chart_extractor.ts Outdated Show resolved Hide resolved
src/xlsx/extraction/chart_extractor.ts Outdated Show resolved Hide resolved
tests/xlsx/xlsx_import.test.ts Outdated Show resolved Hide resolved
@Rachico Rachico force-pushed the master-import-export-trendlines-mera branch 4 times, most recently from e9ca1fb to cbb4df1 Compare December 23, 2024 15:39
@Rachico Rachico requested a review from anhe-odoo December 23, 2024 15:39
@Rachico
[IMP] chart: support import/export of dataset trendlines
9a39663 
This commit introduces the ability to import and export trendlines
associated with datasets in chart configurations.

Task: 4319957
@Rachico Rachico force-pushed the master-import-export-trendlines-mera branch from cbb4df1 to 9a39663 Compare December 24, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhe-odoo anhe-odoo anhe-odoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rachico @robodoo @anhe-odoo